Tests: Ensure test filename and class name align #10643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sirreal
commented
Dec 17, 2025
| * @group https-migration | ||
| */ | ||
| class Tests_HTTPS_Migration extends WP_UnitTestCase { | ||
| class Tests_HttpsMigration extends WP_UnitTestCase { |
Member
Author
There was a problem hiding this comment.
Suggested change
| class Tests_HttpsMigration extends WP_UnitTestCase { | |
| class Tests_HTTPSMigration extends WP_UnitTestCase { |
| * @group https-detection | ||
| */ | ||
| class Tests_HTTPS_Detection extends WP_UnitTestCase { | ||
| class Tests_HttpsDetection extends WP_UnitTestCase { |
Member
Author
There was a problem hiding this comment.
Suggested change
| class Tests_HttpsDetection extends WP_UnitTestCase { | |
| class Tests_HTTPSDetection extends WP_UnitTestCase { |
| * @coversDefaultClass WP_User_Query | ||
| */ | ||
| class Tests_User_Query_Cache extends WP_UnitTestCase { | ||
| class Tests_User_QueryCache extends WP_UnitTestCase { |
Member
Author
There was a problem hiding this comment.
Suggested change
| class Tests_User_QueryCache extends WP_UnitTestCase { | |
| class Tests_User_QueryCache extends WP_UnitTestCase { |
| */ | ||
|
|
||
| class Tests_WpIsValidUtf8TestCase extends WP_UnitTestCase { | ||
| class Tests_Unicode_WpIsValidUtf8 extends WP_UnitTestCase { |
Member
Author
There was a problem hiding this comment.
Suggested change
| class Tests_Unicode_WpIsValidUtf8 extends WP_UnitTestCase { | |
| class Tests_Unicode_WpIsValidUTF8 extends WP_UnitTestCase { |
| * @group formatting | ||
| */ | ||
| class Tests_DeprecatedUtf8EncodeDecodeTest extends WP_UnitTestCase { | ||
| class Tests_Formatting_DeprecatedUtfEncodeDecode extends WP_UnitTestCase { |
Member
Author
There was a problem hiding this comment.
Suggested change
| class Tests_Formatting_DeprecatedUtfEncodeDecode extends WP_UnitTestCase { | |
| class Tests_Formatting_DeprecatedUTFEncodeDecode extends WP_UnitTestCase { |
sirreal
force-pushed
the
tests/fix-test-class-name-filename-match
branch
from
f6cb549 to
ae01369
Compare
Member
Author
|
Abandoning this based on https://core.trac.wordpress.org/ticket/62004. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix class names or filename to match PHPUnit expectations.
PHPUnit can be run with a filename argument:
However, certain test files and test suite class names do not align with PHPUnit expectations and it may fail to run any tests, for example:
Trac ticket: https://core.trac.wordpress.org/ticket/64225
I used this script (and some variations) to detect the files with this problem. The idea being that no tests actually match the filter (so the suite should never fail) but the suite does fail if the test class cannot be found:
bad test files on
trunk(alphabetized)Note that most of the
base.phpclasses are abstract classes meant to be extended, not actually run as a test suite.